feat(list): ✨ add max-results option and automatically page#919
Open
wmcnamee-coreweave wants to merge 2 commits intoankitpokhrel:mainfrom
Open
feat(list): ✨ add max-results option and automatically page#919wmcnamee-coreweave wants to merge 2 commits intoankitpokhrel:mainfrom
wmcnamee-coreweave wants to merge 2 commits intoankitpokhrel:mainfrom
Conversation
wmcnamee-coreweave
force-pushed
the
feat/automatic-pagination
branch
6 times, most recently
from
6874a1f to
f8fccd9
Compare
This change allows users to pass `--max-results` and multiple requests will be made, using the "nextPageToken" from each response to automatically iterate through pages. This provides an enhanced user experience over the need to manually provide `--paginate N:M` and make multiple CLI calls Additionally, as part of this change, some of the search functions were refactored to use functional options, which DRY's the code a bit (there was duplication between v2 and v3 functions)
wmcnamee-coreweave
force-pushed
the
feat/automatic-pagination
branch
from
f8fccd9 to
e45361e
Compare
Author
|
@ankitpokhrel can you take a look at this PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows users to pass
--max-resultsand multiple requests will be made, using the "nextPageToken" from each response to automatically iterate through pages. This provides an enhanced user experience over the need to manually provide--paginate N:Mand make multiple CLI callsAdditionally, as part of this change, some of the search functions were refactored to use functional options, which DRY's the code a bit (there was duplication between v2 and v3 functions)