X Tutup
Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

clean up npm scripts tasks with npm-run-all#54

Merged
wardbell merged 2 commits intoangular:masterfrom
khalillechelt:master
Apr 7, 2016
Merged

clean up npm scripts tasks with npm-run-all#54
wardbell merged 2 commits intoangular:masterfrom
khalillechelt:master

Conversation

@khalillechelt
Copy link
Copy Markdown

Hi this is just a suggestion.

It does not change behavior of the npm scripts tasks but it uses npm-run-all instead of concurrently to run tasks in sequence or in parallel. It makes the scripts just nicer to read.
Also I made the task names more consistent by using colon in task names instead of a dash.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@khalillechelt
Copy link
Copy Markdown
Author

I signed it.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@wardbell
Copy link
Copy Markdown
Contributor

wardbell commented Apr 7, 2016

What is the advantage? I already know concurrently. I don't know npm-run-all. I see that the syntax is a little nicer but now I have to stop and vet that package. I'll keep this here for the future but it's not a priority.

Thanks for the suggestion. I'll get to it when I have time.

@wardbell wardbell merged commit ae1f364 into angular:master Apr 7, 2016
@khalillechelt
Copy link
Copy Markdown
Author

Hi the advantage is just that the npm scripts tasks stay readable and manageable over time as the amount of tasks grow. That is all 😄

I have been using it for a while in multiple projects and love how it cleans up the tasks.

@wardbell
Copy link
Copy Markdown
Contributor

wardbell commented Apr 7, 2016

Aaargh! Accidentally merged. I'm reverting. Sorry.

@khalillechelt
Copy link
Copy Markdown
Author

haha I was wondering what was going on. all good.

@wardbell
Copy link
Copy Markdown
Contributor

wardbell commented Apr 7, 2016

I created new PR #56 that revives your changes. Now I have to fix the other stuff I broke. Nightmare!

Anyone. Will look again later.

@khalillechelt
Copy link
Copy Markdown
Author

👍 alrighty sorry to hear that you broke stuff. hope the fix will go fast!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup