docs(nav): Highlight current nav-index-listing#9974
docs(nav): Highlight current nav-index-listing#9974kentcdodds wants to merge 2 commits intoangular:masterfrom kentcdodds:docs-current-highlight
Conversation
Color the current nav-index-listing item dark red to make it easier to know where you are. Closes #9970
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
@kentcdodds thnx for the PR. At present it seems to be breaking some e2e tests - at the beginning I thought it was Travis flake but after restarting the job a couple of times it looks like a legitimate bug. Could you please have a look? https://travis-ci.org/angular/angular.js/jobs/40415397 |
|
Looking into it now. This is why we love Travis 👍 |
Fixes the build (I think)
|
Looks like that fixed it @pkozlowski-opensource :-) |
|
LGTM, merging |
|
Hmm, I'm just wondering what the I'm going to merge this one as the proposed highlighting is definitively a good thing, but it would be cool to clean-up stuff if we can. |
Color the current nav-index-listing item dark red to make it easier to know where you are.
Closes #9970