This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Update dgeni config to free up paths to protractor tests#9680
Closed
petebacondarwin wants to merge 2 commits intoangular:masterfrom
Closed
Update dgeni config to free up paths to protractor tests#9680petebacondarwin wants to merge 2 commits intoangular:masterfrom
petebacondarwin wants to merge 2 commits intoangular:masterfrom
Conversation
Updates to dgeni-packages 0.10.5 which supports this configurability. Change the dgeni config and protractor config so that we can have protractor tests that are hosted outside the build/docs folder. Provides support for angular#9557 (comment)
These tests are not generated by dgeni and so needed to have the paths to the pages updated manually.
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
Contributor
|
It kind of sucks that this is even necessary --- it would be better to associate as pecific prefix with a specific test suite. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two commits:
The first updates the base path for protractor tests.
The second fixes some manual e2e tests that needed their path changing