chore(jscs): update jscs and update deprecated rules#9616
chore(jscs): update jscs and update deprecated rules#9616hzoo wants to merge 2 commits intoangular:masterfrom hzoo:update-jscs
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
Updated grunt-jscs and deprecated rules: requireLeftStickedOperators and requireRightStickedOperators. Fixes #9429
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
I can also go ahead and add more rules from .jscs.json.todo and associated changes files in this or separate PR |
|
@eltacodeldiablo thanks! this is great. if you'd like to work on more todo items then go ahead, but please send one PR per rule so that it's easy to review and quickly get it. Ideally aim for only one pending PR at a time. These style changes affect many files and if the PR gets stale, it's difficult to merge. cc: @caitp or @petebacondarwin on the PRs so that we can get quickly in before they get stale. |
|
Ok sounds good. |
3 participants
Updated grunt-jscs and deprecated rules:
requireLeftStickedOperators and requireRightStickedOperators.
Fixes #9429