This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Updating $location.search() jsdoc signature#8050
Closed
jpsimons wants to merge 1 commit intoangular:masterfrom
Closed
Updating $location.search() jsdoc signature#8050jpsimons wants to merge 1 commit intoangular:masterfrom
jpsimons wants to merge 1 commit intoangular:masterfrom
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
IgorMinar
pushed a commit
that referenced
this pull request
Jul 2, 2014
Contributor
|
thanks |
blickly
added a commit
to google/closure-compiler
that referenced
this pull request
Jul 3, 2014
This follows from a recent documentation update in angular/angular.js#8050 ------------- Created by MOE: http://code.google.com/p/moe-java MOE_MIGRATED_REVID=70436361
ckknight
pushed a commit
to ckknight/angular.js
that referenced
this pull request
Jul 16, 2014
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes from the way "toKeyValue" specifically checks for === true.
By the way, are the short codes in the description e.g. feat(Some feature) documented anywhere?