fix($compile): replace/templateUrl transclude issue#7772
fix($compile): replace/templateUrl transclude issue#7772petebacondarwin wants to merge 1 commit intoangular:masterfrom
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
So the problem here appears to be if you have:
In this scenario, the transcludeFn is not passed to the transSync nodeLinkFn at link time. (The trans directive is simulating what ng-if does, which is call its transludeFn during a subsequent digest if its value evaluates to true) If the trans directive is not async then the transcludeFn does get passed. In debugging you can see that the delayedNodeLinkFn is not passing the transcludeFn down to the afterTemplateNodeLinkFn |
If a "replace" directive has an async template, which contains a transclusion directive at its root node, then outer transclusions were failing to be passed to this directive. An example would be uses of `ngIf` inside and outside the template. Collaborated with @caitp Closes angular#7183 Closes £7772
petebacondarwin
changed the title
|
LGTM --- might be good to clean up some of the empty lines that the diff adds but it's not that big a deal. |
|
🎊 |
If a "replace" directive has an async template, which contains a transclusion directive at its root node, then outer transclusions were failing to be passed to this directive. An example would be uses of `ngIf` inside and outside the template. Collaborated with @caitp Closes angular#7183 Closes angular#7772
3 participants
See #7183