X Tutup
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Correct example for filter date/'fullDate' in documentation#7350

Closed
Joe8Bit wants to merge 1 commit intoangular:masterfrom
Joe8Bit:patch-1
Closed

Correct example for filter date/'fullDate' in documentation#7350
Joe8Bit wants to merge 1 commit intoangular:masterfrom
Joe8Bit:patch-1

Conversation

@Joe8Bit
Copy link
Copy Markdown
Contributor

@Joe8Bit Joe8Bit commented May 5, 2014

Request Type: docs

How to reproduce:

Component(s):

Impact:

Complexity:

This issue is related to:

Detailed Description:

On the following docs page there is a missing space in giving the equivalent expanded filter for the shortform 'fullDate' filter.

https://docs.angularjs.org/api/ng/filter/date

It gives the equivalent as this:
'fullDate': equivalent to 'EEEE, MMMM d,y' for en_US locale (e.g. Friday, September 3, 2010)
Whereas it should be:
'fullDate': equivalent to 'EEEE, MMMM d, y' for en_US locale (e.g. Friday, September 3, 2010)

Notice the space between the d, and y. A very small issue, but probably worth fixing!

Other Comments:

The equivalent expanded example for 'fullDate' is given as 'EEEE, MMMM d,y' whereas it should be 'EEEE, MMMM d, y' e.g. I added the correct whitespace to the expanded example.

The equivalent expanded example for 'fullDate' is given as 'EEEE, MMMM d,y' whereas it should be 'EEEE, MMMM d, y'. With added whitespace.
@mary-poppins
Copy link
Copy Markdown

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#7350)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mary-poppins
Copy link
Copy Markdown

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@pkozlowski-opensource
Copy link
Copy Markdown
Member

Thnx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup