Fix translations for locale hr-hr and hr#3483
Conversation
|
@ameralimanovic Thnx for this PR. Actually AngularJS uses localized strings from the Closure library, extracted from this file: https://code.google.com/p/closure-library/source/browse/closure/goog/i18n/datetimesymbolsext.js It seems like there are 2 forms for a month name in the closure library, while in AngularJS there is only one form. @chirayuk I know that you've been working on the extraction process so I'm wondering if we should support 2 different forms. |
|
@pkozlowski-opensource Thanks for the informations about the Closure library. Yes, there are 2 forms for month names, specific for some languages. One is the nominative case (https://en.wikipedia.org/wiki/Nominative_case) and the other is genitive case (https://en.wikipedia.org/wiki/Genitive_case). Many languages have only the nominative case for month names, therefore it's the default. The nominative case can be used always, but the genitive case can be used only in some situations. This PR fixes the hr-hr locale, to switch from genitive to nominative and to have more flexible and consistent translations. For example, the serbian locale sr-latn-* files are correct (nominative case), but the croatian hr-hr file should be fixed as soon as possible. Both languages have nominative and genitive case for month names. Please merge this PR. |
|
we can't merge this as is. the file being edited is auto-generated by otherwise the hand-made changes will be lost, next time we regenerate the locale files. |
|
it seems that closure already has genitive variants of the months, so likely the best course of action is to change our closureSlurper to grab those in addition to nominative variant. then when rendering dates using locale rules we should use genitive case whenever possible. |
|
@btford in languages which have two cases for months, the genitive case is being stored in MONTH array and the nominative case in STANDALONEMONTH array. |
|
Same problem in other slavic languages. |
Wrong cases for months in croatian language have been fixed, in order to show the months correctly in a calendar.