Remove unneeded window reference#15610
Conversation
The document object is global.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Can't rely on UA sniffing and certainly not in a unit test. Must fix the related code in AngularJS, rather than just skipping over the test based on the UA string.
|
I signed the CLA. |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Also, the global For some reason I don't see that file in my fork (at least not on GitHub). (?) |
|
Couldn't imagine using AngularJS in Node (e.g. with jsdom), but apparently some can. :) |
The document object is global.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: