X Tutup
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(RootRouter): describe your change...#14396

Closed
jwcarroll wants to merge 1 commit intoangular:masterfrom
jwcarroll:patch-1
Closed

docs(RootRouter): describe your change...#14396
jwcarroll wants to merge 1 commit intoangular:masterfrom
jwcarroll:patch-1

Conversation

@jwcarroll
Copy link
Copy Markdown
Contributor

@jwcarroll jwcarroll commented Apr 8, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Documentation update

What is the current behavior? (You can also link to an open issue here)

Simple typo

What is the new behavior (if this is a feature change)?

Fixed typo

Does this PR introduce a breaking change?

Nope

Please check if the PR fulfills these requirements

Other information:

Simple typo fix from betweent he to between the

@jwcarroll
docs(RootRouter): describe your change...
9f74b41 
Simple typo fix from `betweent he` to `between the`
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 8, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 8, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jwcarroll
Copy link
Copy Markdown
Contributor Author

jwcarroll commented Apr 8, 2016

I signed it!

@googlebot
Copy link
Copy Markdown

googlebot commented Apr 8, 2016

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link
Copy Markdown

googlebot commented Apr 8, 2016

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 8, 2016
Narretz pushed a commit that referenced this pull request Apr 8, 2016
@jwcarroll @Narretz
docs(ngComponentRouter): fix typo
cb80137 
Simple typo fix from `betweent he` to `between the`

Closes #14396
@Narretz Narretz closed this in 0cbe7fb Apr 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jwcarroll @googlebot
X Tutup