This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(injector): make sure we call Function.prototype.toString not an override#14361
Closed
a510 wants to merge 3 commits intoangular:masterfrom
Closed
fix(injector): make sure we call Function.prototype.toString not an override#14361a510 wants to merge 3 commits intoangular:masterfrom
a510 wants to merge 3 commits intoangular:masterfrom
Conversation
… an override use Function.prototype.toString.call instead of fn.toString, because the user might override the toString function of the "fn" instance, without knowing it's being used by the injector.
Contributor
|
Hi @a510, the change looks fine, but a test would be mostly welcome. |
Contributor
|
and this should be marked as |
a510
changed the title
gkalpak
pushed a commit
that referenced
this pull request
Apr 11, 2016
…otated properly Closes #14361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Bug fix
What is the current behavior? (You can also link to an open issue here)
the injector uses fn.toString to extract function arguments
What is the new behavior (if this is a feature change)?
the injector uses Function.prototype.toString.call to avoid calling an override
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information:
use Function.prototype.toString.call instead of fn.toString, because the user might override the toString function of the "fn" instance, without knowing it's being used by the injector.