This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(helpers): fix error message generation for toHaveBeenCalledOnce[With] matchers#14275
Closed
gkalpak wants to merge 2 commits intoangular:masterfrom
Closed
test(helpers): fix error message generation for toHaveBeenCalledOnce[With] matchers#14275gkalpak wants to merge 2 commits intoangular:masterfrom
toHaveBeenCalledOnce[With] matchers#14275gkalpak wants to merge 2 commits intoangular:masterfrom
Conversation
…[With]` matchers Jasmine 2.4 (maybe earlier) does not support returning an array containing both the "normal" and the negative error messages. It will always concatenate them.
gkalpak
referenced
this pull request
Mar 19, 2016
Highlights: New mechanism to run async tests as Jasmine 2 removed `runs`, `waits` and `waitsFor` The functions `iit`, `ddescribe` and `tthey` were renamed `fit`, `fdescribe` and `fthey` as the originals came from Karma, Karma no longer bundles Jasmine and the new function name comes from Jasmine. Closes #14226
Contributor
|
LGTM. I wonder though if we can test our custom matchers? Testception? |
gkalpak
added a commit
that referenced
this pull request
Apr 9, 2016
…[With]` matchers Jasmine 2.4 (maybe earlier) does not support returning an array containing both the "normal" and the negative error messages. It will always concatenate them. Closes #14275
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the error messages for 2 of our internal matchers (
toHaveBeenCalledOnce()andtoHaveBeenCalledOnceWith()). The previous format (returning an array containing both the "normal" and the negative error messages), is not supported in Jasmine 2.4. It will always concatenate the messages.Related to #14226.
There is also a 2nd commit (to be squashed when merging) with minor fixes (typos and testcase descriptions) and a couple of TODOs.