This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngAria): add support for ngReadonly#14140
Closed
m-amr wants to merge 1 commit intoangular:masterfrom
Closed
Conversation
m-amr
force-pushed
the
add_ariaReadonly
branch
3 times, most recently
from
1de0bee to
008fe0c
Compare
|
|
||
| scope.$apply('val = true'); | ||
| expect(element.attr('aria-readonly')).toBe('true'); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
I have removed the Nitpick: Redundant newline.
Member
|
The code LGTM. Thx for working on this 👍
|
handle aria-readonly based on ng-readonly
feat angular#14077
m-amr
force-pushed
the
add_ariaReadonly
branch
from
008fe0c to
265cb72
Compare
Contributor
Author
|
I have updated the documentation to include Thanks for your feedback. |
Contributor
|
@gkalpak can you give this another look / merge it? It LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat
feat(ngAria): add support for
ngReadonly#14077add support for
ngReadonlyno
handle aria-readonly based on ng-readonly
fix #14077