This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Services): improve the code example#14139
Closed
thorn0 wants to merge 1 commit intoangular:masterfrom
Closed
docs(guide/Services): improve the code example#14139thorn0 wants to merge 1 commit intoangular:masterfrom
thorn0 wants to merge 1 commit intoangular:masterfrom
Conversation
A factory that doesn't return anything is a bad example of a factory.
Narretz
pushed a commit
that referenced
this pull request
Feb 28, 2016
A factory that doesn't return anything is a bad example of a factory. Closes #14139
Narretz
pushed a commit
that referenced
this pull request
Feb 28, 2016
A factory that doesn't return anything is a bad example of a factory. Closes #14139
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs update
A bad code example. A factory that doesn't return anything is a bad example of a factory.