X Tutup
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Components): add missing $ctrl#14138

Closed
mattjanssen wants to merge 1 commit intoangular:masterfrom
mattjanssen:patch-3
Closed

docs(guide/Components): add missing $ctrl#14138
mattjanssen wants to merge 1 commit intoangular:masterfrom
mattjanssen:patch-3

Conversation

@mattjanssen
Copy link
Copy Markdown
Contributor

@mattjanssen mattjanssen commented Feb 26, 2016

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Doc fix
  • What is the current behavior? (You can also link to an open issue here)
    {hero: hero}
  • What is the new behavior (if this is a feature change)?
    {hero: $ctrl.hero}
  • Does this PR introduce a breaking change?
    No
  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
  • [ x Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Other information:

@mattjanssen
docs(guide/Components): add missing $ctrl
50cc8e5 
docs(guide/Components): add missing $ctrl

The new component example does not work as is. It needs a missing reference to $ctrl.
@Narretz Narretz self-assigned this Feb 28, 2016
Narretz pushed a commit that referenced this pull request Feb 28, 2016
@mattjanssen @Narretz
docs(guide/Components): add missing $ctrl
d1fa20d 
docs(guide/Components): add missing $ctrl

The new component example does not work as is. It needs a missing reference to $ctrl.

Closes #14138

Closes #14143
@Narretz Narretz closed this in 30a7e3a Feb 28, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@Narretz Narretz

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mattjanssen @Narretz @googlebot
X Tutup