Component router guide#14131
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm. |
petebacondarwin
force-pushed
the
component-router-guide
branch
from
5abbc22 to
1185f1a
Compare
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
|
Looks good overall (there are a few typis here and there, but the diff is not displayed to comment 😞) It might be better to remove the Crisis Center bits from the example, since it's not mentioned in the guide. (Maybe provide the whole app (with Crisis Center) at the end as a more complete example. Regarding including the whole router code in the example, it's ugly, but I can live with it as a temporary work-around. |
| */ | ||
|
|
||
| /** | ||
| * @name ngLink |
There was a problem hiding this comment.
The sample code used here for configuring routes and the ngLink is incorrect.
There was a problem hiding this comment.
Yes - work in progress :-)
petebacondarwin
force-pushed
the
component-router-guide
branch
from
1185f1a to
1a2dab0
Compare
|
FYI I published |
|
Yes! |
|
npmcdn doesn't seem to cope with the scoped package |
|
I can see the files just fine (e.g. angular_1_router.js). |
petebacondarwin
force-pushed
the
component-router-guide
branch
from
1a2dab0 to
1b50e9b
Compare
petebacondarwin
force-pushed
the
component-router-guide
branch
from
1b50e9b to
37a25a3
Compare
petebacondarwin
force-pushed
the
component-router-guide
branch
from
37a25a3 to
f697ccc
Compare
petebacondarwin
force-pushed
the
component-router-guide
branch
from
f697ccc to
c1c29c3
Compare
petebacondarwin
force-pushed
the
component-router-guide
branch
from
c1c29c3 to
6a336ba
Compare
5 participants
docs update!
So this is still a draft but it could be good enough to merge and iterate on.
The big problem is that, at the moment, I had to include the whole of the router code in the runnable example.
You can see a demo of the guide here: https://ci.angularjs.org/job/angular.js-pete/1073/artifact/build/docs/guide/component-router