This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAria): Apply ARIA attrs correctly#13483
Closed
marcysutton wants to merge 1 commit intoangular:masterfrom
Closed
fix(ngAria): Apply ARIA attrs correctly#13483marcysutton wants to merge 1 commit intoangular:masterfrom
marcysutton wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
Well done @marcysutton - thanks. We will get this in after 1.5.0 is released |
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
709b79c to
82c6438
Compare
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
82c6438 to
de718c8
Compare
Member
There was a problem hiding this comment.
These links should be {@link ng/directive/ngValue} and {@link ng/directive/ngChecked}.
marcysutton
force-pushed
the
ngaria-aria-attr-fixes
branch
from
de718c8 to
9af2245
Compare
Member
There was a problem hiding this comment.
I'm not sure if ng/directive/ngrequired (instead of ng/directive/ngRequired) works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Where appropriate, ngAria now applies ARIA to custom controls only, not native inputs. Because of this, support for
aria-multilineon textareas has been removed.New support added for ngValue, ngChecked, and ngRequired, along with updated documentation. Also supports ngTrueValue and ngFalseValue as part of ngModel.
Closes #13078
Closes #11374
Closes #11830
cc @petebacondarwin (I got this done finally! 😄)