X Tutup
Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(contributing): add commitizen commit message formatting#13194

Closed
stephensauceda wants to merge 2 commits intoangular:masterfrom
stephensauceda:commitizen
Closed

chore(contributing): add commitizen commit message formatting#13194
stephensauceda wants to merge 2 commits intoangular:masterfrom
stephensauceda:commitizen

Conversation

@stephensauceda
Copy link
Copy Markdown
Contributor

@stephensauceda stephensauceda commented Oct 28, 2015

This adds npm run commit to package.json scripts to assist in formatting git commit messages with commitizen.

Closes #12730

@kentcdodds
Copy link
Copy Markdown

kentcdodds commented Oct 28, 2015

Would love to see this merged! Great work @stephensauceda 👍

@Narretz Narretz added this to the Backlog milestone Oct 29, 2015
@Narretz
Copy link
Copy Markdown
Contributor

Narretz commented Oct 29, 2015

Looks like a worthwhile addition. Wdyt @petebacondarwin ?

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Oct 29, 2015

Sure, as long as it is in keeping with our conventions

@kentcdodds
Copy link
Copy Markdown

kentcdodds commented Oct 29, 2015

It is. Never fear :-) and you may also be interested in:
http://npm.im/validate-commit-msg

On Thu, Oct 29, 2015, 4:27 PM Pete Bacon Darwin notifications@github.com
wrote:

Sure, as long as it is in keeping with our conventions

—
Reply to this email directly or view it on GitHub
#13194 (comment).

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Oct 30, 2015

Merging

@petebacondarwin
Copy link
Copy Markdown
Contributor

petebacondarwin commented Oct 30, 2015

Yes, this looks cool. Although I tend to use a UI tool for rebasing and updating commits :-)

@jimthedev
Copy link
Copy Markdown

jimthedev commented Oct 30, 2015

@petebacondarwin Eventually I'd love to see some GUIs hook into this to be able to offer prompts. There is an open (pie in the sky) issue for it here: commitizen/cz-cli#45

The GUIs would just need to offer some hook we could call then wrap the Inquirer.js interface for prompts. Again, this may never happen, but it would be nice to offer it as an opt-in integration.

petebacondarwin added a commit that referenced this pull request Oct 31, 2015
@petebacondarwin
chore(package.json): add commitizen, adapter and npm script
1bba358 
Closes #13194
gkalpak pushed a commit to gkalpak/angular.js that referenced this pull request Nov 23, 2015
@stephensauceda @gkalpak
chore(package.json): add commitizen, adapter and npm script
b396f9a 
Closes angular#13194
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

cla: yes frequency: high severity: inconvenient type: chore

Projects

None yet

Milestone

Backlog - won't fix

Development

Successfully merging this pull request may close these issues.

6 participants

@stephensauceda @kentcdodds @Narretz @petebacondarwin @jimthedev @googlebot
X Tutup