This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor: use isDefined and isUndefined consistently#12831
Closed
lucastetreault wants to merge 2 commits intoangular:masterfrom
lucastetreault:master
Closed
refactor: use isDefined and isUndefined consistently#12831lucastetreault wants to merge 2 commits intoangular:masterfrom lucastetreault:master
lucastetreault wants to merge 2 commits intoangular:masterfrom
lucastetreault:master
Conversation
Contributor
|
Hi, thanks for the PR. Can you please
|
Contributor
|
@lgalfaso thanks for triaging this one. I think that if it looks good then we can do the squash and commit message fix up when merging to save on cycles. Thanks @lucastetreault for fixing this very long running issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix any place that x == undefined or x != undefined
to use isUndefined and isDefined instead
Closes #4365