This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngAnimate): do not assume $document[0] exists#11997
Closed
tjokimie wants to merge 1 commit intoangular:masterfrom
Closed
fix(ngAnimate): do not assume $document[0] exists#11997tjokimie wants to merge 1 commit intoangular:masterfrom
tjokimie wants to merge 1 commit intoangular:masterfrom
Conversation
Use document.body instead of $document[0].body. Enable mocking of $window without having to add an empty document object into it. Closes angular#11964
Contributor
|
@matsko can you take a look at this? I'm not sure how strict we should be with these injections. |
Contributor
|
I think this is not an issue. If you want to mock |
Author
Contributor
|
The reason why we use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use document.body instead of $document[0].body. Enable mocking of $window
without having to add an empty document object into it.
Closes #11964