This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(sanitize): new implementation of the html sanitized parser#11790
Closed
mhevery wants to merge 1 commit intoangular:masterfrom
Closed
chore(sanitize): new implementation of the html sanitized parser#11790mhevery wants to merge 1 commit intoangular:masterfrom
mhevery wants to merge 1 commit intoangular:masterfrom
Conversation
test/ngSanitize/sanitizeSpec.js
Outdated
This was referenced May 5, 2015
mhevery
force-pushed
the
sanitize
branch
5 times, most recently
from
e64868f to
4ab972b
Compare
Contributor
Author
|
@IgorMinar I don't know how to fix the build. Can you have a look? |
Contributor
|
you didn't update docs and used the wrong object to throw the error. pull the commit from this branch: https://github.com/angular/angular.js/compare/master...IgorMinar:sanitize-fix?expand=1 review the docs for correctness.. |
This implementation is based on inert document Closes angular#11442 Closes angular#11443
Contributor
Author
|
@IgorMinar merged your changes here, you can close your branch. |
Contributor
|
The sanitization process looks fine, but this PR makes some unexpected html behavior changes that change how html is rendered. eg it('should not duplicate <br> tags', function() {
expectHTML('<br />').not.toEqual('<br></br>');
expectHTML('<br>').not.toEqual('<br></br>');
}); |
Contributor
|
This PR has been superseded by #12524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implementation is based on inert document