This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(validators): check if viewValue is empty for maxlength#10898
Closed
Narretz wants to merge 1 commit intoangular:masterfrom
Closed
fix(validators): check if viewValue is empty for maxlength#10898Narretz wants to merge 1 commit intoangular:masterfrom
Narretz wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
|
LGTM - feel free to merge. You can add the extra tests if you like. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@petebacondarwin This is the bug you found where $isEmpty is called with the modelValue. To make this consistent, we should also add this test to all other validators. Does this make sense to you?