This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($parse): remove references to last arguments to a fn call#10894
Closed
vojtajina wants to merge 1 commit intoangular:masterfrom
Closed
fix($parse): remove references to last arguments to a fn call#10894vojtajina wants to merge 1 commit intoangular:masterfrom
vojtajina wants to merge 1 commit intoangular:masterfrom
Conversation
This can be an issue if running (and killing) multiple apps/injectors on the same page. The `args` array holds references to all previous arguments to a function call and thus they cannot be garbage-collected. In a regular (one app/injector on a page) app, this is not an issue.
Contributor
|
If the |
vojtajina
added a commit
that referenced
this pull request
Jan 29, 2015
This can be an issue if running (and killing) multiple apps/injectors on the same page. The `args` array holds references to all previous arguments to a function call and thus they cannot be garbage-collected. In a regular (one app/injector on a page) app, this is not an issue. Closes #10894
Contributor
|
Is there any point keeping the array around if it gets set to a length of 0 each time? Does that still avoid reallocating each time? |
|
Just a note: this issue could have still created memory leaks in a single-injector app when using Passing a function argument refering to the DOM (such as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be an issue if running (and killing) multiple apps/injectors on the same page. The
argsarray holds references to all previous arguments to a function call and thus they cannot be garbage-collected.In a regular (one app/injector on a page) app, this is not an issue.
cc @aaronfrost