Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@googlebot done.

CLAs look good, thanks!

+1 @caitp

I was just looking at this too and this is just what I was thinking.
If we are going to support copying Float32Array then we should support all type arrays. Unfortunately IE9 doesn't support them so we need to tread carefully but @caitp's ideas are the direction to go.

@DropsOfSerenity - if you would like to update your PR accordingly that would be great.

• Update the error doc to be more generic
• Create a isTypedArray() method instead of specific one. Perhaps we could compare src.constuctor.name with /(Uint8(Clamped)?)|(Uint16)|(Uint32)|(Int8)|(Int16)|(Int32)|(Float(32)|(64))Array/
• Update the copy method accordingly
• Update the docs

Excellent, I'll get to it, on a side-note I don't know why the CI build keeps failing, all the tests pass over here.

Don't worry. We are having flakiness issues connecting to SauceLabs and BrowserStack when running tests on Travis

@caitp @petebacondarwin

Alright thanks for the great advice, I've added a new commit that supports all TypedArrays. I did try using constructor.name instead however that resulted in a memory leak for reasons I don't understand.

One other approach I was thinking of could be to use instanceOf, but then I'd have to add a check to make sure the Type being compared to actually exists (in the case of ie9- it doesn't)

Either way this solution seems to be working well, updated the tests to check all TypedArrays.

@caitp sweet looks like CI finally passed :)

party =) I'll take a look at this later today, gotta finish up a quick patch I'm writing first

LGTM

I lied, I guess I did review the PR before finishing my patch :3 It looks good to me, just fix up the nits and squash the commits

@caitp Ok i squashed with my changes. :3

good stuff, looks ready to merge to me

i guess this was really a feature rather than a fix >_- oh well, not changing that message :>

This change is great... have you considered exposeding istypedArray as angular.isTypedArray?