fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias#4973
Closed
chrisfitz wants to merge 0 commit intoangular:masterfrom
chrisfitz:paths-plugin
Closed
fix(@ngtools/webpack): fix paths-plugin to allow '*' as alias#4973chrisfitz wants to merge 0 commit intoangular:masterfrom chrisfitz:paths-plugin
chrisfitz wants to merge 0 commit intoangular:masterfrom
chrisfitz:paths-plugin
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Meligy
reviewed
Feb 24, 2017
Contributor
Meligy
left a comment
There was a problem hiding this comment.
Is it possible to write a test for this?
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #3443 that didn't quite fix #3441.
This simplifies the plugin by sending the request path to
ts.nodeModuleNameResolverand lets Typescript figure out its true path rather than looping through all the path options manually like it was previously doing.