fix(webpack): paths plugin modification to not allow multiple requests more than once#3443
fix(webpack): paths plugin modification to not allow multiple requests more than once#3443jkuri wants to merge 1 commit intoangular:masterfrom
Conversation
0c169e5 to
aa236c1
Compare
|
Can you add an e2e test for this PR? |
|
@hansl working on it. |
7056ece to
b0b4543
Compare
|
What's the status for those tests failing? |
|
solution itself is not okay. I am suspicious of a bug in webpack resolver, but not sure. I'll try to find a solution for this elsewhere in |
|
FWIW, the solution I've been using to get the paths to work in my non-angular-cli webpack configuration prior to attempting to integrate |
567ca72 to
119452e
Compare
|
@chrisfitz thanks for the tip! @hansl can you please check again? |
ff9e114 to
a756422
Compare
hansl
left a comment
There was a problem hiding this comment.
Seems like the complexity of the code comes from not replacing the pattern.
| let withStarCapturing = excapedAlias.replace('\\*', '(.*)'); | ||
| aliasPattern = new RegExp(`^${withStarCapturing}$`); | ||
| } else { | ||
| aliasPattern = new RegExp(`^${excapedAlias}$`); |
There was a problem hiding this comment.
So the pattern now is ^\\*$ which only matches a star? That seems really wrong.
bf6753e to
b8dde3d
Compare
eec0860 to
1c5426c
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
closes #3441