fix(@angular-devkit/build-angular): exclude map files from 'bundle' budgets#14017
Merged
alexeagle merged 1 commit intoangular:masterfrom May 30, 2019
NickGeek:bundle-map-fix
Merged
fix(@angular-devkit/build-angular): exclude map files from 'bundle' budgets#14017alexeagle merged 1 commit intoangular:masterfrom NickGeek:bundle-map-fix
alexeagle merged 1 commit intoangular:masterfrom
NickGeek:bundle-map-fix
Conversation
alan-agius4
added
target: major
alan-agius4
requested changes
Mar 29, 2019
Collaborator
alan-agius4
left a comment
alan-agius4
left a comment
There was a problem hiding this comment.
Hi, thanks for this.
While the change itself looks good the test always passed irrespective of this change or not.
alan-agius4
added
state: WIP
and removed
target: patch
Contributor
Author
|
Ah, sorry about that! I'll go and write a proper test :-) |
alan-agius4
added
target: patch
alan-agius4
approved these changes
May 29, 2019
Contributor
Author
|
Thanks for getting that sorted and merged in! Sorry I couldn't get that fixed up earlier, uni got a bit hectic. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#11999 raised the issue of bundle budgets for the
initialtype including source maps. That issue was fixed in #12012. However, as was noted by @Tonio31, source maps should also be excluded frombundle-type budgets.