fix(@angular-devkit/build-angular): exclude .map files from budget …#12012
Merged
vikerman merged 2 commits intoangular:masterfrom Aug 28, 2018
alan-agius4:fix_exclude_map_from_budgets
Merged
fix(@angular-devkit/build-angular): exclude .map files from budget …#12012vikerman merged 2 commits intoangular:masterfrom alan-agius4:fix_exclude_map_from_budgets
.map files from budget …#12012vikerman merged 2 commits intoangular:masterfrom
alan-agius4:fix_exclude_map_from_budgets
Conversation
…calculations Closes #11999
clydin
reviewed
Aug 27, 2018
| const initialChunks = this.compilation.chunks.filter(chunk => chunk.isOnlyInitial()); | ||
| const size: number = initialChunks | ||
| .reduce((files, chunk) => [...files, ...chunk.files], []) | ||
| .filter((file: string) => !/\.map$/.test(file)) |
Member
There was a problem hiding this comment.
endsWith please. Should be significantly faster and more obvious as to intent.
Collaborator
Author
There was a problem hiding this comment.
good point, updated
alan-agius4
added
the
target: patch
clydin
approved these changes
Aug 27, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
exclude
.mapfiles from budget calculationsCloses #11999