fix(@angular-devkit/build-angular): only collect coverage from files …#11974
Merged
vikerman merged 1 commit intoangular:masterfrom Aug 28, 2018
alan-agius4:fix_coverage_sourceroot
Merged
fix(@angular-devkit/build-angular): only collect coverage from files …#11974vikerman merged 1 commit intoangular:masterfrom alan-agius4:fix_coverage_sourceroot
vikerman merged 1 commit intoangular:masterfrom
alan-agius4:fix_coverage_sourceroot
Conversation
…under `sourceRoot` In some cases when having libraries within the workspace this is causing a `Maximum call stack size exceeded`, Also for libraries coverage should be collected with the respective `ng test` Closes #11934
alan-agius4
added
the
target: patch
filipesilva
approved these changes
Aug 28, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only collect coverage from files under
sourceRootIn some cases when having libraries within the workspace this is causing a
Maximum call stack size exceeded, Also for libraries coverage should be collected with the respectiveng testCloses #11934