fix(ViewContainer) removeChild called with null parent#999
Closed
divdavem wants to merge 1 commit intoangular:masterfrom
Closed
fix(ViewContainer) removeChild called with null parent#999divdavem wants to merge 1 commit intoangular:masterfrom
divdavem wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
Contributor
There was a problem hiding this comment.
Something like
var len = view.nodes.length;
if (len == 0) return;
var parent = view.nodes[0].parentNode;
for (var i = len - 1; i >= 0; --i) {
DOM.removeChild(parent, view.nodes[i]);
}
divdavem
force-pushed
the
nestedTemplates
branch
from
691d6ac to
a6abae7
Compare
Contributor
Author
In view_container.js, templateElement.parentNode can be null when two template tags are nested in one another. Accessing the parent node through view.nodes[0].parentNode fixes the problem. closes angular#997
divdavem
force-pushed
the
nestedTemplates
branch
from
a6abae7 to
744cd2d
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains a fix for #997.
In
view_container.js,this.templateElement.parentNodecan be null when two template tags are nested in one another. I replaced the call toDOM.removeChildby a call toDOM.removewhich automatically finds the right parent node.