style(global): group multiple imports from same module#8209
style(global): group multiple imports from same module#8209alexcastillo wants to merge 1 commit intoangular:masterfrom
Conversation
1587293 to
d065551
Compare
|
Oops! I forgot I already wrote a fix for this but was waiting for a different PR to land first. It did, and I didn't come back to this one. The issue is actually worded inaccurately. The root problem here is not the current imports, but that it is possible for developers to continue introducing more duplication. If the root problem remains, then after merging this PR we will soon be back in the same state. See my PR #7859 (comment) for this. Alternatively, @mprobst was working on organizing imports in clang-format as indicated in that comment. Either way I'd prefer to add the enforcement mechanism at the same time we clean up the existing duplication. |
|
Got it. Feel free to close this PR if it doesn't apply anymore. |
|
It'll take a while to add import sorting to |
|
Do we want to get this merged in the meantime, then? |
|
Sure, this is still an improvement. Thanks for contributing! |
|
doesn't apply cleanly on g3_v2_0, merging to master only. |
|
Merging PR #8209 on behalf of @rkirov to branch presubmit-rkirov-pr-8209. |
|
merge conflict https://travis-ci.org/angular/angular/builds/125715456, you need to rebase on top of master |
d065551 to
5b8ba70
Compare
|
@rkirov rebased! |
|
Merging PR #8209 on behalf of @rkirov to branch presubmit-rkirov-pr-8209. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Only code style changes
code style: multiple imports allowed from same module #7802
No
No
✌️
Closes #7802
cc @alexeagle