X Tutup
Skip to content

style(global): group multiple imports from same module#8209

Closed
alexcastillo wants to merge 1 commit intoangular:masterfrom
alexcastillo:ngcontrib-codestyle
Closed

style(global): group multiple imports from same module#8209
alexcastillo wants to merge 1 commit intoangular:masterfrom
alexcastillo:ngcontrib-codestyle

Conversation

@alexcastillo
Copy link
Copy Markdown
Contributor

Closes #7802

cc @alexeagle

@alexeagle
Copy link
Copy Markdown
Contributor

Oops! I forgot I already wrote a fix for this but was waiting for a different PR to land first. It did, and I didn't come back to this one.

The issue is actually worded inaccurately. The root problem here is not the current imports, but that it is possible for developers to continue introducing more duplication. If the root problem remains, then after merging this PR we will soon be back in the same state.

See my PR #7859 (comment) for this.

Alternatively, @mprobst was working on organizing imports in clang-format as indicated in that comment.

Either way I'd prefer to add the enforcement mechanism at the same time we clean up the existing duplication.

@alexcastillo
Copy link
Copy Markdown
Contributor Author

@alexeagle

Got it. Feel free to close this PR if it doesn't apply anymore.

@mprobst
Copy link
Copy Markdown
Contributor

mprobst commented Apr 24, 2016

It'll take a while to add import sorting to clang-format.

@alexcastillo
Copy link
Copy Markdown
Contributor Author

Do we want to get this merged in the meantime, then?

@alexeagle
Copy link
Copy Markdown
Contributor

Sure, this is still an improvement. Thanks for contributing!

@alexeagle alexeagle added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Apr 25, 2016
@rkirov
Copy link
Copy Markdown
Contributor

rkirov commented Apr 26, 2016

doesn't apply cleanly on g3_v2_0, merging to master only.

@mary-poppins
Copy link
Copy Markdown

Merging PR #8209 on behalf of @rkirov to branch presubmit-rkirov-pr-8209.

@rkirov
Copy link
Copy Markdown
Contributor

rkirov commented Apr 26, 2016

merge conflict https://travis-ci.org/angular/angular/builds/125715456, you need to rebase on top of master

@alexcastillo
Copy link
Copy Markdown
Contributor Author

@rkirov rebased!

@mary-poppins
Copy link
Copy Markdown

Merging PR #8209 on behalf of @rkirov to branch presubmit-rkirov-pr-8209.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

code style: multiple imports allowed from same module

6 participants

X Tutup