Closed
Conversation
vsavkin
added
action: review
Contributor
Author
There was a problem hiding this comment.
UrlMarshaller? UrlSerializer/UrlDeserializer?
vsavkin
force-pushed
the
simple_router_implementation
branch
from
4c0eca8 to
ae565f3
Compare
vsavkin
force-pushed
the
simple_router_implementation
branch
3 times, most recently
from
3916d74 to
5f57b81
Compare
Contributor
Author
There was a problem hiding this comment.
rename into pathFromRoot
vsavkin
added
action: merge
Contributor
Author
|
Did a walkthrough with Misko |
vsavkin
force-pushed
the
simple_router_implementation
branch
from
5f57b81 to
8ca81dd
Compare
| return new Tree<UrlSegment>(this._parseNodes(url)); | ||
| } | ||
|
|
||
| private _parseNodes(url: string): UrlSegment[] { |
Member
There was a problem hiding this comment.
Isn't this method essentially doing url.split('/').map(segment => new UrlSegment(segment, {}, '')) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.