feat(compiler): Wire offline compilation as a build step. by alexeagle · Pull Request #8098 · angular/angular

alexeagle · 2016-04-16T00:40:40Z

alexeagle · 2016-04-16T00:55:13Z

tools/metadata/src/collector.ts

@chuckjaz here is where this function signature could go into a host interface. I suppose I would just add that interface declaration in this file, maybe before the MetadataCollector class?

Something like,

export interface MetadataCollectorHost { resolveModuleFromPath?(path: string): string; }

That way we could add another method without breaking the API.

robwormald · 2016-04-17T00:04:55Z

i know this is still WIP, so sorry for the comments, but one bit of weirdness:

import {Component} from 'angular2/core' 

@Component({ ... })
export SomeClass {}

doesn't work, and throws (after some debugging) with a 'No Directive annotation found on SomeClass', error.

using

import {Component} from 'angular2/src/core/metadata'

and doing the same thing works and successfully generates a .template file. The test code here does the same thing (took me a while to recognize that), is that expected? Some artifact of recent changes?

mhevery · 2016-04-17T17:47:50Z

tools/compiler_cli/test/basic.html

why Igor? What does this flag do?

mhevery · 2016-04-17T17:49:55Z

Very exciting!!!

alexeagle · 2016-04-19T00:18:21Z

@chuckjaz Rob has a good point above, that I reverse-map based on the path where a module was discovered, to workaround path mapping issues. Any import from a re-export has this problem, because the string ./src/core/metadata is the location where Component is loaded in angular2/core.ts.

It won't be a problem if you use the collector.ts from head, and angular2 comes from regular node moduleResolution with no pathMapping. That's how users would use it. Just a problem in our test case.

We need a real chat about #8082 ...

chuckjaz · 2016-04-19T01:08:03Z

We should go over this tomorrow.

tbosch · 2016-04-25T16:33:18Z

gulpfile.js

Does your PR still require typescript@next? If not, maybe use gulp-typescript?

Yes, I still use typescript@next to compile the compiler (it uses baseUrl/paths to resolve the 'angular2' imports)

But, the issue referenced here is resolved, so it may be possible to use gulp-typescript instead.
(Not that it adds anything, I want the tsconfig.json to express everything).
Will try upgrading it.

Tried newer gulp-typescript, it is still broken. Filed a new issue and referenced in this comment.

Note that I think we should stop using gulp-typescript and store our configuration in tsconfig.json instead. Maybe in a followup PR I'll remove it :)

Preserves constructor calls in addition to function calls. Introduced a special case for forwardRef() similar to CONST_EXPR.

These worked in Dart because they were effectively exported even without the export keyword. Without exporting these symbols, they are not produced in .metadata.json files, which leaves dangling references from the Decorators that use them.

- pass a baseUrl for asset resolution from static symbols - fixes in StaticReflector to work with a path-aware host see angular#7483

This tool lets us re-write TypeScript sources before entering the emit pipeline. For example, we lower Decorators to the tree-shakable Annotation form.

see angular#7483.

alexeagle · 2016-04-29T05:02:48Z

Cleaned up and ready for review

mary-poppins · 2016-04-29T06:47:53Z

Merging PR #8098 on behalf of @alexeagle to branch presubmit-alexeagle-pr-8098.

angular-automatic-lock-bot · 2019-09-08T08:21:23Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

alexeagle assigned tbosch Apr 16, 2016

googlebot added the cla: yes label Apr 16, 2016

alexeagle force-pushed the compiler_cli branch from 20769cc to 5e5998e Compare April 16, 2016 00:54

alexeagle reviewed Apr 16, 2016
View reviewed changes

mhevery reviewed Apr 17, 2016
View reviewed changes

tools/compiler_cli/test/basic.html Outdated

Copy link
Copy Markdown

Contributor

mhevery Apr 17, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why Igor? What does this flag do?

alexeagle force-pushed the compiler_cli branch from 5e5998e to 2fe6675 Compare April 18, 2016 23:25

alexeagle force-pushed the compiler_cli branch from 2fe6675 to de09a74 Compare April 19, 2016 00:20

alexeagle force-pushed the compiler_cli branch 9 times, most recently from d92c839 to 96f1ef1 Compare April 24, 2016 04:06

tbosch reviewed Apr 25, 2016
View reviewed changes

alexeagle assigned tbosch and unassigned ThomasBurleson Apr 25, 2016

alexeagle force-pushed the compiler_cli branch 6 times, most recently from 2595054 to e01e5b8 Compare April 29, 2016 00:46

chuckjaz and others added 6 commits April 28, 2016 21:31

fix(8223): Preserve Provider expressions

7c0d497

Preserves constructor calls in addition to function calls. Introduced a special case for forwardRef() similar to CONST_EXPR.

fix(codegen): event handler has boolean return type

ca40ef5

fix(metadata): expose Providers in metadata

8bf6ef6

These worked in Dart because they were effectively exported even without the export keyword. Without exporting these symbols, they are not produced in .metadata.json files, which leaves dangling references from the Decorators that use them.

chore(compiler): refactoring for offline compiler cli

c493d88

- pass a baseUrl for asset resolution from static symbols - fixes in StaticReflector to work with a path-aware host see angular#7483

chore(compiler): add dependency on tsickle

33e53c9

This tool lets us re-write TypeScript sources before entering the emit pipeline. For example, we lower Decorators to the tree-shakable Annotation form.

feat(offline compiler): a replacement for tsc that compiles templates

78946fe

see angular#7483.

alexeagle force-pushed the compiler_cli branch from e01e5b8 to b5c8c5b Compare April 29, 2016 05:00

alexeagle mentioned this pull request Apr 29, 2016

fix(8223): Preserve Provider expressions #8263

Closed

3 tasks

alexeagle force-pushed the compiler_cli branch from b5c8c5b to 9fce265 Compare April 29, 2016 05:33

chore(build): fix formatting and tests

7f2fb0e

alexeagle force-pushed the compiler_cli branch from 9fce265 to 7f2fb0e Compare April 29, 2016 06:32

tbosch added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 29, 2016

alexeagle added action: merge The PR is ready for merge by the caretaker zomg_admin: do merge labels Apr 29, 2016

mary-poppins removed the zomg_admin: do merge label Apr 29, 2016

tbosch closed this in 96ae348 Apr 29, 2016

angular-automatic-lock-bot bot unassigned tbosch Sep 8, 2019

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

Conversation

alexeagle commented Apr 16, 2016

Uh oh!

alexeagle Apr 16, 2016

Choose a reason for hiding this comment

Uh oh!

chuckjaz Apr 18, 2016

Choose a reason for hiding this comment

Uh oh!

robwormald commented Apr 17, 2016

Uh oh!

mhevery Apr 17, 2016

Choose a reason for hiding this comment

Uh oh!

mhevery commented Apr 17, 2016

Uh oh!

alexeagle commented Apr 19, 2016

Uh oh!

chuckjaz commented Apr 19, 2016

Uh oh!

tbosch Apr 25, 2016

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 25, 2016

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexeagle Apr 25, 2016

Choose a reason for hiding this comment

Uh oh!

alexeagle commented Apr 29, 2016

Uh oh!

mary-poppins commented Apr 29, 2016

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

alexeagle Apr 25, 2016 •

edited

Loading