X Tutup
Skip to content

chore(gulpfile): turn off mangle for prod bundles#7988

Closed
PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS:mangle-false
Closed

chore(gulpfile): turn off mangle for prod bundles#7988
PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS:mangle-false

Conversation

@PatrickJS
Copy link
Copy Markdown
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix
  • What is the current behavior? (You can also link to an open issue here)
    problems with templates invoking props after the class is mangled
  • What is the new behavior (if this is a feature change)?
    unmangle minified code
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    larger minified bundles

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 8, 2016

Can you run clang-format See: https://travis-ci.org/angular/angular/jobs/121830874#L2659 on this change?

@mhevery mhevery added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Apr 8, 2016
@PatrickJS
Copy link
Copy Markdown
Contributor Author

@mhevery sorry about that, it's updated

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 9, 2016

Thank you it is scheduled for merge. (Hopefully travis will go green)

@mary-poppins
Copy link
Copy Markdown

Merging PR #7988 on behalf of @alxhub to branch presubmit-alxhub-pr-7988.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup