X Tutup
Skip to content

chore(typings): remove tsd and install typings#7985

Closed
jeffbcross wants to merge 1 commit intoangular:masterfrom
jeffbcross:tsd-2-typings
Closed

chore(typings): remove tsd and install typings#7985
jeffbcross wants to merge 1 commit intoangular:masterfrom
jeffbcross:tsd-2-typings

Conversation

@jeffbcross
Copy link
Copy Markdown
Contributor

@jeffbcross jeffbcross commented Apr 8, 2016

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Changes our typings manager to typings instead of deprecated tsd.
  • What is the current behavior? (You can also link to an open issue here)
  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

  • Other information:

Closes #7982

@jeffbcross jeffbcross added comp: build/pipeline action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 8, 2016
alexeagle
alexeagle reviewed Apr 8, 2016
View reviewed changes
.travis.yml Outdated
Copy link
Copy Markdown
Contributor

@alexeagle alexeagle Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you know how typings avoids github rate limiting? it may cause flakes

Copy link
Copy Markdown
Contributor Author

@jeffbcross jeffbcross Apr 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add it based on Configuration FAQ.

I mis-read an issue comment that lead me to believe it wasn't necessary.

@jeffbcross jeffbcross mentioned this pull request Apr 9, 2016
Closed
@alexeagle alexeagle added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 9, 2016
@alexeagle alexeagle assigned jeffbcross and unassigned alexeagle Apr 9, 2016
@alexeagle
Copy link
Copy Markdown
Contributor

alexeagle commented Apr 9, 2016

nice. I don't understand why the clean-shrinkwrap delta is so big - did you upgrade everything? or is that just typings has lots of deps?

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 9, 2016

@jeffbcross Looks like CI is failing. Could you have a look?

@jeffbcross
Copy link
Copy Markdown
Contributor Author

jeffbcross commented Apr 11, 2016

Spent some time trying to understand why TS2Dart was choking on this change, to no avail. Going to wait on @alexeagle to land #8003 so I can accomplish my original goal of upgrading RxJS.

@jeffbcross jeffbcross closed this Apr 11, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jeffbcross jeffbcross

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

chore: use typings instead of tsd internally

4 participants

@jeffbcross @alexeagle @mhevery @googlebot
X Tutup