chore(format): update to latest formatter#7958
chore(format): update to latest formatter#7958alexeagle wants to merge 1 commit intoangular:masterfrom
Conversation
alexeagle
commented
Apr 8, 2016
alexeagle
commented
- Please check if the PR fulfills these requirements
- [ X ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
- [ X ] Tests for the changes have been added (for bug fixes / features)
- [ X ] Docs have been added / updated (for bug fixes / features)
alexeagle
added
the
action: review
|
LGTM, though I'm not quite sure what to review here. The changes are mechanical and seem OK, right? Are you missing the change to package.json. shinkwrap etc? |
There was a problem hiding this comment.
This looks like a bug though, could you file one?
There was a problem hiding this comment.
sure, but what is the bug? You'd expect valueAccessors to fit on the line above following the decorators?
There was a problem hiding this comment.
indentation is way too high for the class body, isn't it?
There was a problem hiding this comment.
this indentation is still the constructor parameters.
class body starts with super(); below and looks fine...
There was a problem hiding this comment.
I think ngOnChanges should be indented +4 (2 for class, 2 for method), but it's on what looks like +10?
alexeagle
force-pushed
the
upgrade_clang_format
branch
from
8f9b2d4 to
2ed25fd
Compare
|
shrinkwrap change is included (or the lint job would have failed https://travis-ci.org/angular/angular/jobs/121578928) |
alexeagle
added
pr_state: LGTM
and removed
action: review
alexeagle
force-pushed
the
upgrade_clang_format
branch
from
2ed25fd to
a3dc55e
Compare
alexeagle
force-pushed
the
upgrade_clang_format
branch
from
a3dc55e to
613ec11
Compare
|
Merging PR #7958 on behalf of @alxhub to branch presubmit-alxhub-pr-7958. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
