X Tutup
Skip to content

fix(upgrade): make upgradeAdapter upgrade angular 1 components correctly#7951

Closed
alxhub wants to merge 1 commit intoangular:masterfrom
alxhub:pr/7588
Closed

fix(upgrade): make upgradeAdapter upgrade angular 1 components correctly#7951
alxhub wants to merge 1 commit intoangular:masterfrom
alxhub:pr/7588

Conversation

@alxhub
Copy link
Copy Markdown
Member

@alxhub alxhub commented Apr 7, 2016

#7588 with squashed commits

With this fix, the $onInit function of an upgraded angular 1 component is called and input bindings (<) are created.
@alxhub alxhub added pr_state: LGTM action: merge The PR is ready for merge by the caretaker cla: yes labels Apr 7, 2016
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@mary-poppins
Copy link
Copy Markdown

Merging PR #7951 on behalf of @alxhub to branch presubmit-alxhub-pr-7951.

@jonricaurte
Copy link
Copy Markdown

Is it possible to have another beta release? I was hoping this would get into beta 14 since we are currently running into this issue everywhere since we upgraded most of our directives to components when 1.5 was released. Thanks!

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Apr 8, 2016

@jonricaurte I am sorry, it is unlikely that we will cut another release until wednesday.

@jonricaurte
Copy link
Copy Markdown

@mhevery Thanks for the update! Looking forward to both this pr and shuhei/babel-plugin-angular2-annotations#19 to get into releases so then the upgrade path should be smoother.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: no

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

X Tutup