chore(build): Clean-up TypeScript build#7941
Conversation
There was a problem hiding this comment.
this this right? shouldn't we achieve this by setting rootDir to inputPath instead?
There was a problem hiding this comment.
They are both the same but I can change this to this.compilerOptions.rootDir if that is more clear.
There was a problem hiding this comment.
the rootDir is already set to inputPath. no?
There was a problem hiding this comment.
Yes. They are equivalent. I felt it was more clear with this.treeInputPath as it is much more clear that these files are from the broccoli input tree.
There was a problem hiding this comment.
I misunderstood what you were saying here. Sorry about that.
TypeScript requires all files to be under rootDir and doesn't resolve relative files returned via getScriptFileNames() to rootDir. It is expected that getScriptFileNames() returns resolved filenames which is what this does. Changing rootDir, at least for 1.7.5, is not sufficient.
IgorMinar
added
pr_state: LGTM
action: cleanup
|
lgtm except for the dart analyzer failure on travis + the seeminly duplicate inputPath prefixing via both |
|
can you please update the commit message to |
The TypeScript parser now only references files that are in broccoli trees.
|
The |
chuckjaz
added
action: merge
|
@chuckjaz thanks! |
|
Merging PR #7941 on behalf of @alxhub to branch presubmit-alxhub-pr-7941. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
Chore
Broccoli builds refer to files outside the input tree requiring custom file name resolution.
Broccoli builds only refer to files in the input tree and no longer require custom file name resolution.
No.
The TypeScript parser now only references files that are in broccoli trees.