X Tutup
Skip to content

feat(compiler): Add implementation for a XHR that uses a template cache to load template files.#7940

Closed
vikerman wants to merge 1 commit intoangular:masterfrom
vikerman:cached_xhr
Closed

feat(compiler): Add implementation for a XHR that uses a template cache to load template files.#7940
vikerman wants to merge 1 commit intoangular:masterfrom
vikerman:cached_xhr

Conversation

@vikerman
Copy link
Copy Markdown
Contributor

@vikerman vikerman commented Apr 6, 2016

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature - Provide a XHR implementation that uses a template cache to avoid actually making an XHR. Exports CACHED_TEMPLATE_PROVIDER through angular2/platform/browser and angular2/platform/testing/browser which can be used by applications and tests to use the cached XHR implementation.
  • What is the current behavior? (You can also link to an open issue here)
    Support preloading of templates, at least for testing #4051
  • What is the new behavior (if this is a feature change)?
    If the application or test uses the cached XHR implementation by setting up the provider for XHR it will use the template cache instead of making an actual XHR. This can be useful for writing fakeAsync tests.
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:

Useful for avoiding doing an actual XHR during testing.
Part of the solution for #4051 (Other part is a Karma plugin that will create the template cache).

@vikerman vikerman added this to the Angular 2 Release Candidate milestone Apr 6, 2016
@vikerman
Copy link
Copy Markdown
Contributor Author

vikerman commented Apr 6, 2016

cc @juliemr

@lacolaco
Copy link
Copy Markdown
Contributor

lacolaco commented Apr 7, 2016

Is this just for testing?
I want a similar system for application to preload (programmatical load) component's template refered by templateUrl.
It is like ng-template of ng1.

@ericmartinezr
Copy link
Copy Markdown
Contributor

ericmartinezr commented Apr 7, 2016

@laco0416 that's what the new compiller will do, will convert the templateUrl's in files intead of requesting them

@lacolaco
Copy link
Copy Markdown
Contributor

lacolaco commented Apr 7, 2016

@ericmartinezr sounds good. thx!

tbosch
tbosch reviewed Apr 7, 2016
View reviewed changes
modules/angular2/src/platform/browser/xhr_cache.ts Outdated
Copy link
Copy Markdown
Contributor

@tbosch tbosch Apr 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use window but the global variable exported from angular2/src/facade/lang.ts

Copy link
Copy Markdown
Contributor Author

@vikerman vikerman Apr 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tbosch tbosch added pr_state: LGTM action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 7, 2016
@vikerman
feat(compiler): Add an implementation for XHR that uses a template ca…
8da9419 
…che to load template files.

Useful for avoiding doing an actual XHR during testing.
Part of the solution for #4051 (Other part is a Karma plugin that will create the template cache).
@vikerman vikerman added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 8, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Apr 8, 2016

Merging PR #7940 on behalf of @alxhub to branch presubmit-alxhub-pr-7940.

@mhevery mhevery closed this in a596b88 Apr 8, 2016
@juliemr juliemr mentioned this pull request Jun 21, 2016
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

Angular 2 Release Candidate

Development

Successfully merging this pull request may close these issues.

7 participants

@vikerman @lacolaco @ericmartinezr @mary-poppins @tbosch @alxhub @googlebot
X Tutup