X Tutup
Skip to content

chore(build): Produce .d.ts files for build tools #7763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chuckjaz wants to merge 1 commit into from
Closed

chore(build): Produce .d.ts files for build tools #7763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 17 additions & 16 deletions gulpfile.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,25 +1093,26 @@ gulp.task('!build.tools', function() {
.pipe(tsc({
target: 'ES5',
module: 'commonjs',
declaration: true,
// Don't use the version of typescript that gulp-typescript depends on
// see https://github.com/ivogabe/gulp-typescript#typescript-version
typescript: require('typescript')
}))
.on('error',
function(error) {
// nodejs doesn't propagate errors from the src stream into the final
// stream so we are
// forwarding the error into the final stream
stream.emit('error', error);
})
.pipe(sourcemaps.write('.'))
.pipe(gulp.dest('dist/tools'))
.on('end', function() {
var AngularBuilder =
require('./dist/tools/broccoli/angular_builder').AngularBuilder;
angularBuilder =
new AngularBuilder({outputPath: 'dist', dartSDK: DART_SDK, logs: logs});
});
}));
stream =
merge2([stream.js.pipe(gulp.dest('dist/tools')), stream.dts.pipe(gulp.dest('dist/tools'))])
.on('error',
function(error) {
// nodejs doesn't propagate errors from the src stream into the final
// stream so we are
// forwarding the error into the final stream
stream.emit('error', error);
})
.pipe(sourcemaps.write('.'))
.on('end', function() {
var AngularBuilder = require('./dist/tools/broccoli/angular_builder').AngularBuilder;
angularBuilder =
new AngularBuilder({outputPath: 'dist', dartSDK: DART_SDK, logs: logs});
});

return stream;
});
Expand Down
13 changes: 6 additions & 7 deletions tools/broccoli/angular_builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,17 +6,16 @@ var path = require('path');
var printSlowTrees = require('broccoli-slow-trees');
var Q = require('q');

type ProjectMap = {
export type ProjectMap = {
[key: string]: boolean
};

type Options = {
export type Options = {
projects: ProjectMap;
noTypeChecks: boolean;
generateEs6: boolean;
useBundles: boolean;
}
;
noTypeChecks: boolean;
generateEs6: boolean;
useBundles: boolean;
};

/**
* BroccoliBuilder facade for all of our build pipelines.
Expand Down
2 changes: 1 addition & 1 deletion tools/broccoli/broccoli-lodash.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import path = require('path');
var _ = require('lodash');
import {wrapDiffingPlugin, DiffingBroccoliPlugin, DiffResult} from './diffing-broccoli-plugin';

interface LodashRendererOptions {
export interface LodashRendererOptions {
encoding?: string;
context?: any;
// files option unsupported --- use Funnel on inputTree instead.
Expand Down
4 changes: 1 addition & 3 deletions tools/broccoli/broccoli-merge-trees.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,7 @@ import {wrapDiffingPlugin, DiffingBroccoliPlugin, DiffResult} from './diffing-br

var isWindows = process.platform === 'win32';

interface MergeTreesOptions {
overwrite?: boolean;
}
export interface MergeTreesOptions { overwrite?: boolean; }

function outputFileSync(sourcePath, destPath) {
let dirname = path.dirname(destPath);
Expand Down
2 changes: 1 addition & 1 deletion tools/broccoli/broccoli-tree-stabilizer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ class TreeStabilizer implements BroccoliTree {
}


export default function stabilizeTree(inputTree) {
export default function stabilizeTree(inputTree): BroccoliTree {
return new TreeStabilizer(inputTree);
}
2 changes: 1 addition & 1 deletion tools/broccoli/diffing-broccoli-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ export interface DiffingBroccoliPlugin {
}


type DiffingPluginWrapperFactory = (inputTrees: (BroccoliTree | BroccoliTree[]), options?) =>
export type DiffingPluginWrapperFactory = (inputTrees: (BroccoliTree | BroccoliTree[]), options?) =>
BroccoliTree;


Expand Down
X Tutup