feat(Compiler): Allow overriding the projection selector#7742
Closed
vicb wants to merge 1 commit intoangular:masterfrom
Closed
feat(Compiler): Allow overriding the projection selector#7742vicb wants to merge 1 commit intoangular:masterfrom
vicb wants to merge 1 commit intoangular:masterfrom
Conversation
Contributor
vicb
commented
Mar 23, 2016
vicb
commented
- Please check if the PR fulfills these requirements
- The commit message follows our guidelines:
- Tests for the changes have been added (for bug fixes / features)
- Docs have been added / updated (for bug fixes / features)
Contributor
There was a problem hiding this comment.
Move this out of the if right after the var projectionSelector =.
tbosch
added
the
action: cleanup
vicb
removed
the
action: cleanup
fixes angular#6303 BREAKING CHANGE: For static content projection, elements with *-directives are now matched against the element itself vs the template before. <p *ngIf="condition" foo></p> Before: // Use the implicit template for projection <ng-content select="template"></ng-content> After: // Use the actual element for projection <ng-content select="p[foo]"></ng-content>
|
Merging PR #7742 on behalf of @kara to branch presubmit-kara-pr-7742. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.