refactor(NgZoneImpl): ensure zone spec is available#7702
Closed
PatrickJS wants to merge 1 commit intoangular:masterfrom
Closed
refactor(NgZoneImpl): ensure zone spec is available#7702PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS wants to merge 1 commit intoangular:masterfrom
Conversation
trace could be true (in dev mode) while there is no long stack trace spec
| } | ||
| if (trace) { | ||
| if (trace && Zone['longStackTraceZoneSpec']) { | ||
| this.inner = this.inner.fork(Zone['longStackTraceZoneSpec']); |
Contributor
Author
There was a problem hiding this comment.
including a warning might be a good idea
mhevery
added
pr_state: LGTM
action: merge
|
Merging PR #7702 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7702. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix
an error is thrown
Avoids an error when there is no long stack trace
trace could be true (in dev mode) while there is no long stack trace spec
cc @mhevery