feat(dart/transform): Use angular2/platform/browser as bootstrap lib#7647
Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
Closed
feat(dart/transform): Use angular2/platform/browser as bootstrap lib#7647kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq wants to merge 1 commit intoangular:masterfrom
Conversation
kegluneq
added
comp: dart-transformer
action: review
kegluneq
force-pushed
the
breaking_bootstrap
branch
2 times, most recently
from
adc31a9 to
b9e11cb
Compare
kegluneq
changed the title
kegluneq
force-pushed
the
breaking_bootstrap
branch
from
b9e11cb to
4b6b12d
Compare
Update the Angular 2 transformer to recognize `package:angular2/platform/browser.dart` as the library which exports the `bootstrap` function. Update playground, examples, benchmarks, & tests to import bootstrap from platform/browser.
kegluneq
force-pushed
the
breaking_bootstrap
branch
from
4b6b12d to
fd457f4
Compare
Contributor
|
LGTM |
mhevery
added
pr_state: LGTM
and removed
action: review
|
Merging PR #7647 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7647. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @IgorMinar
Update the Angular 2 transformer to recognize
package:angular2/platform/browser.dartas the library which exportsthe
bootstrapfunction.Update playground examples, benchmarks, & tests to import bootstrap from
platform/browser.