X Tutup
Skip to content

I18n: Xmb Serializer#7620

Closed
vsavkin wants to merge 4 commits intoangular:masterfrom
vsavkin:xmb_serializer
Closed

I18n: Xmb Serializer#7620
vsavkin wants to merge 4 commits intoangular:masterfrom
vsavkin:xmb_serializer

Conversation

@vsavkin
Copy link
Copy Markdown
Contributor

@vsavkin vsavkin commented Mar 15, 2016

No description provided.

@vsavkin vsavkin changed the title Xmb serializer I18n: Xmb Serializer Mar 15, 2016
@vsavkin vsavkin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Mar 15, 2016
mhevery
mhevery reviewed Mar 15, 2016
View reviewed changes
modules/angular2/src/facade/lang.dart Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Mar 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was under the impression that importing this was expensive. Check with @yjbanov

Copy link
Copy Markdown
Contributor

@yjbanov yjbanov Mar 15, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just importing, no. If it's only used in the compiler and tree-shaken off before going to production, it won't do anything bad. If pulled into production, it will eat ~15kb as it implements the full Uri spec.

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Mar 15, 2016

LGTM

@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 15, 2016
@mhevery mhevery assigned vsavkin and unassigned mhevery Mar 15, 2016
@vsavkin vsavkin added the action: merge The PR is ready for merge by the caretaker label Mar 15, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 16, 2016

Merging PR #7620 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7620.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 17, 2016

Merging PR #7620 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7620.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 17, 2016

Merging PR #7620 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7620.

@jelbourn
Copy link
Copy Markdown
Contributor

jelbourn commented Mar 17, 2016

Mary Poppins hates this PR so I'm pushing it manually.

@jelbourn jelbourn closed this in 8326ab3 Mar 17, 2016
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@vsavkin vsavkin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vsavkin @mhevery @mary-poppins @jelbourn @yjbanov @googlebot
X Tutup