fix(router): RouterOutlet loads component twice in a race condition#7545
Closed
mhevery wants to merge 1 commit intoangular:masterfrom
Closed
fix(router): RouterOutlet loads component twice in a race condition#7545mhevery wants to merge 1 commit intoangular:masterfrom
mhevery wants to merge 1 commit intoangular:masterfrom
Conversation
mhevery
force-pushed
the
issue7497
branch
2 times, most recently
from
33fafd9 to
dbe4485
Compare
Contributor
Author
mhevery
added
pr_state: LGTM
action: merge
Contributor
Author
|
@tbosch LGTM, per our discussion |
jelbourn
changed the title
|
Merging PR #7545 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7545. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug fix #7497
During race condition it is possible that the
routerOutletwill activate a component multiple times.Ensure that activation can happen only once.
No