X Tutup
Skip to content

chore(core): remove @View annotation#7495

Closed
btford wants to merge 1 commit intoangular:masterfrom
btford:remove-view-decorator
Closed

chore(core): remove @View annotation#7495
btford wants to merge 1 commit intoangular:masterfrom
btford:remove-view-decorator

Conversation

@btford
Copy link
Copy Markdown
Contributor

@btford btford commented Mar 8, 2016

Removes deprecated @View annotation API

  • What is the current behavior? (You can also link to an open issue here)

Related to #7363

  • What is the new behavior (if this is a feature change)?
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
  • Other information:

@btford btford added action: review The PR is still awaiting reviews from at least one requested reviewer hotlist: A2 Blocking labels Mar 8, 2016
mhevery
mhevery reviewed Mar 9, 2016
View reviewed changes
modules/angular2/src/core/metadata.ts Outdated
Copy link
Copy Markdown
Contributor

@mhevery mhevery Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can leave the export here. (Just remove it from the public surface)

Copy link
Copy Markdown
Contributor

@mhevery mhevery Mar 9, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see the public one is exported as *. So this is fine. (ignore the comment)

@mhevery
Copy link
Copy Markdown
Contributor

mhevery commented Mar 9, 2016

LGTM, can you prepare the google3?

@mhevery mhevery assigned btford and unassigned mhevery Mar 9, 2016
@mhevery mhevery added pr_state: LGTM and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 9, 2016
@btford btford force-pushed the remove-view-decorator branch 3 times, most recently from ae7dd36 to 04f9293 Compare March 14, 2016 21:44
@btford btford force-pushed the remove-view-decorator branch from 04f9293 to be53b8b Compare March 14, 2016 22:16
@btford
Copy link
Copy Markdown
Contributor Author

btford commented Mar 14, 2016

Waiting on one travis flake and one internal flake, but otherwise this should be good to go.

@tbosch might be interested in rebasing on top of this quickly after it lands.

@btford btford added the action: merge The PR is ready for merge by the caretaker label Mar 14, 2016
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 14, 2016

Merging PR #7495 on behalf of @martine to branch presubmit-martine-pr-7495.

@mhevery mhevery closed this in f9fb72f Mar 14, 2016
@0x-r4bbit
Copy link
Copy Markdown
Contributor

0x-r4bbit commented Mar 15, 2016

@btford @mhevery prolly already too late, but this is a breaking change as @View has been optional, now it's gone.

I know some ppl are relying on it. Can we update the commit message, before this goes into master?

@MilosStanic MilosStanic mentioned this pull request Mar 15, 2016
Closed
@jongalloway jongalloway mentioned this pull request Mar 15, 2016
Closed
@mhevery mhevery mentioned this pull request Mar 17, 2016
Closed
@jongalloway jongalloway mentioned this pull request Mar 18, 2016
Closed
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 8, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@btford btford

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@btford @mhevery @mary-poppins @0x-r4bbit @evmar @googlebot
X Tutup