X Tutup
Skip to content

fix(angular1_router): generate hash-bang links correctly#7489

Closed
petebacondarwin wants to merge 4 commits intoangular:masterfrom
petebacondarwin:issue-7423
Closed

fix(angular1_router): generate hash-bang links correctly#7489
petebacondarwin wants to merge 4 commits intoangular:masterfrom
petebacondarwin:issue-7423

Conversation

@petebacondarwin
Copy link
Copy Markdown
Contributor

@petebacondarwin petebacondarwin commented Mar 8, 2016

See #7423

@googlebot
Copy link
Copy Markdown

googlebot commented Mar 8, 2016

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@petebacondarwin petebacondarwin mentioned this pull request Mar 8, 2016
Closed
gkalpak
gkalpak reviewed Mar 13, 2016
View reviewed changes
modules/angular1_router/lib/facades.es5 Outdated
Copy link
Copy Markdown
Member

@gkalpak gkalpak Mar 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about hashPrefix ?

Copy link
Copy Markdown
Contributor Author

@petebacondarwin petebacondarwin Mar 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot

petebacondarwin and others added 2 commits March 21, 2016 11:06
@petebacondarwin
chore(angular1_router): tighten up the build regex replacement
4e54bb5
@davidreher @petebacondarwin
fix(angular_1_router): ng-link is generating wrong hrefs
f314770 
At the moment ng-link is generating html5mode URLs for `href`s.
Instead it should check whether or not html5mode is enabled and create
the `href`s accordingly. The renaming in the `getLink` function is
aligning it to `RouterLink`'s `_updateLink`.

Closes angular#7423
@petebacondarwin
Copy link
Copy Markdown
Contributor Author

petebacondarwin commented Mar 21, 2016

@davidreher & @mgol I have made some updates to the code and tests for this PR. Can you take look?

@petebacondarwin petebacondarwin added type: bug/fix action: review The PR is still awaiting reviews from at least one requested reviewer P2: required and removed state: WIP labels Mar 21, 2016
@davidreher
Copy link
Copy Markdown
Contributor

davidreher commented Mar 21, 2016

LGTM

@btford btford added pr_state: LGTM cla: yes action: merge The PR is ready for merge by the caretaker and removed cla: no action: review The PR is still awaiting reviews from at least one requested reviewer labels Mar 22, 2016
@btford
Copy link
Copy Markdown
Contributor

btford commented Mar 22, 2016

LGTM!

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Mar 22, 2016

Merging PR #7489 on behalf of @jelbourn to branch presubmit-jelbourn-pr-7489.

@mhevery mhevery closed this in fb6d791 Mar 22, 2016
@petebacondarwin petebacondarwin deleted the issue-7423 branch September 2, 2017 14:43
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@btford btford

Labels

action: merge The PR is ready for merge by the caretaker cla: yes type: bug/fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@petebacondarwin @googlebot @davidreher @btford @mary-poppins @gkalpak @jelbourn
X Tutup