refactor(dart/transform): Migrates tests to use package:test#7475
Closed
kegluneq wants to merge 1 commit intoangular:masterfrom
Closed
refactor(dart/transform): Migrates tests to use package:test#7475kegluneq wants to merge 1 commit intoangular:masterfrom
kegluneq wants to merge 1 commit intoangular:masterfrom
Conversation
Pt 3 of migrating from package:guinness + package:unittest => package:test. This PR migrates DirectiveProcessor & InlinerForTest unit tests.
kegluneq
added
comp: dart-transformer
action: review
Member
|
LGTM once it looks good to Travis. |
juliemr
added
pr_state: LGTM
and removed
action: review
Author
|
@juliemr Thanks for the quick reviews |
Author
|
@vikerman , fyi this PR touches only test files -- there is no behavior change whatsoever. |
|
Merging PR #7475 on behalf of @vikerman to branch presubmit-vikerman-pr-7475. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/cc @vsavkin , @tbosch as you may be touching these files as well
Pt 3 of migrating from package:guinness + package:unittest => package:test.
This PR migrates DirectiveProcessor & InlinerForTest unit tests.