X Tutup
Skip to content

feat(TAG_DEFINITIONS): include <meta> and <base>#7455

Closed
PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS:patch-5
Closed

feat(TAG_DEFINITIONS): include <meta> and <base>#7455
PatrickJS wants to merge 1 commit intoangular:masterfrom
PatrickJS:patch-5

Conversation

@PatrickJS
Copy link
Copy Markdown
Contributor

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit-message-format
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    fix template parser from not understanding <base> and <meta> tags
  • What is the current behavior? (You can also link to an open issue here)
    HTML template parser doesn't recognize the element tags as self-closing
  • What is the new behavior (if this is a feature change)?
    allows for <base> and <meta> to be self-closing
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    N/A
  • Other information:

needed to parse index.html as a component template

needed to parse index.html as a component template
@jelbourn jelbourn added pr_state: LGTM action: merge The PR is ready for merge by the caretaker labels Mar 7, 2016
@vikerman
Copy link
Copy Markdown
Contributor

vikerman commented Mar 8, 2016

TAP "green".

@mary-poppins
Copy link
Copy Markdown

Merging PR #7455 on behalf of @vikerman to branch presubmit-vikerman-pr-7455.

@angular-automatic-lock-bot
Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

X Tutup